ymodem:Fix bugs and improve the usage of python scripts #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Timeout processing 2.clear error count when received successfully once 3.fix the bug of insufficient header memory application Signed-off-by: anjiahao <anjiahao@xiaomi.com>
anjiahao1
force-pushed
the
esp32s3
branch
2 times, most recently
from
5c7f066 to
51e0848
Compare
pkarashchenko
approved these changes
Jul 28, 2023
|
@anjiahao1 style warning still exist |
anjiahao1
force-pushed
the
esp32s3
branch
2 times, most recently
from
396ee00 to
14ef5a7
Compare
Get help to use ./sbrb.py -h
./sbrb.py -h
usage: sbrb.py [-h] [-k KBLOCKSIZE] [-t TTY] [-b BAUDRATE] [-r [RECVFROM ...]] [-s SENDTO] [--debug DEBUG] [filelist ...]
positional arguments:
filelist if filelist is valid, that is sb, else is rb
options:
-h, --help show this help message and exit
-k KBLOCKSIZE, --kblocksize KBLOCKSIZE
This opthin can set a customsize block size to transfer
-t TTY, --tty TTY Serial path
-b BAUDRATE, --baudrate BAUDRATE
-r [RECVFROM ...], --recvfrom [RECVFROM ...]
recvfile from board path like this: ./sbrb.py -r <file1 [file2 [file 3]...]> -t /dev/ttyUBS0
-s SENDTO, --sendto SENDTO
send file to board path like this: ./sbrb.py -s <path on board> -t /dev/ttyUBS0 <file1 [file2 [file3] ...]>
--debug DEBUG This opthin is save debug log on host
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
rb_main.c:219:42: warning: 'snprintf' output may be truncated before the last format character [-Wformat-truncation=] 219 | snprintf(temp, PATH_MAX, "%s/%s", priv->foldname, Signed-off-by: anjiahao <anjiahao@xiaomi.com>
xiaoxiang781216
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ymodem:Fix bugs and improve the usage of python scripts
1.Timeout processing
2.clear error count when received successfully once
3.fix the bug of insufficient header memory application
Impact
ymodem
Testing
esp32s3:nsh with mincom sbrb.py