Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools refine #594

Merged
merged 8 commits into from
Mar 21, 2020
Merged

Tools refine #594

merged 8 commits into from
Mar 21, 2020

Conversation

xiaoxiang781216
Copy link
Contributor

No description provided.

@xiaoxiang781216 xiaoxiang781216 force-pushed the tools-refine branch 2 times, most recently from 5b00a0f to 80bc959 Compare March 20, 2020 09:48
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaoxiang781216 this breaks on make oldconfig - See image in comment

…istence check."

This reverts commit bf3ffdd.

Change-Id: Ia858ca1aab79a6c599cf93d2701515951bdc7b80
@xiaoxiang781216 xiaoxiang781216 force-pushed the tools-refine branch 2 times, most recently from bb299ee to 52192a9 Compare March 20, 2020 13:08
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defconfig change now is AOK.

version.sh script fails if not under git. That may be the NEW intent, it was not that way in the past.

@davids5 davids5 self-requested a review March 20, 2020 13:55
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any Idea on how to add an test case in this repo, for a relative path custom board?

@xiaoxiang781216
Copy link
Contributor Author

Any Idea on how to add an test case in this repo, for a relative path custom board?

We can let the relative path point to the normal location:
boards/arch/chip/board/configs/xxx
and enable the custom board related config

@patacongo
Copy link
Contributor

Any Idea on how to add an test case in this repo, for a relative path custom board?

There is no real requirement that the test case be truly a custom board with external board support. I think we could create a sim configuration, perhaps called'custom', that could behave like a custom board in how it is configured.

I maybe overlooking somesomething, but I think it is just a matter of setting up all of the CONFIG_BOARD_CUSTOM* values and configuring the sim configuration as though it were a custom board.

@xiaoxiang781216
Copy link
Contributor Author

Any Idea on how to add an test case in this repo, for a relative path custom board?

There is no real requirement that the test case be truly a custom board with external board support. I think we could create a sim configuration, perhaps called'custom', that could behave like a custom board in how it is configured.

I maybe overlooking somesomething, but I think it is just a matter of setting up all of the CONFIG_BOARD_CUSTOM* values and configuring the sim configuration as though it were a custom board.

Yes, we can put the board in the normal location, but define CONFIG_BOARD_CUSTOM* to trigger the custom board logic.

@xiaoxiang781216
Copy link
Contributor Author

@davids5 do you have any more concern? If not, please help merge this PR, thanks.

tools/configure.sh Outdated Show resolved Hide resolved
tools/configure.sh Outdated Show resolved Hide resolved
…igured

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I19eddc3d4e6650eace2482c3cce8fbb07aadc04b
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and fix the typo error and remove if/else nesting

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: Ife0c80d396417e8eb37e43d0883f272d4b9247a0
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: I6c928ac4574721aacb87be27c979ca8ae146a4ce
since we can achieve the same effect by passing V=1 to make

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: Id3d4464e2d30871763b40067b3162b793e99c98f
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
Copy link
Contributor Author

@Ouss4 The new PR fix all issue you report, please take a look.

Copy link
Member

@Ouss4 Ouss4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaoxiang781216 LGTM. Thanks.

@davids5
Copy link
Contributor

davids5 commented Mar 21, 2020

@xiaoxiang781216, @Ouss4 What do you think: rebased merge or squash?

@Ouss4
Copy link
Member

Ouss4 commented Mar 21, 2020

I think this one should be rebased, the commits are fairly independent.

@davids5 davids5 merged commit 0456b70 into apache:master Mar 21, 2020
@davids5
Copy link
Contributor

davids5 commented Mar 21, 2020

@Ouss4 - Agreed!

@xiaoxiang781216 xiaoxiang781216 deleted the tools-refine branch March 22, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants