fs/sync: add sync api #5999
Merged
fs/sync: add sync api #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you have a plan to actually implement them? |
|
If there are no plans to implement then both could be handled as an empty defines at application layer. |
No, add them for iozone tools only. |
|
There is currently no good idea to implement them, so assume they will always succeed |
|
Then maybe it is more easy to handle this at iozone tools integration level only? |
|
@xiaoxiang781216 @Donny9 can we close this PR? |
|
No, sync isn't implemented yet. |
xiaoxiang781216
changed the title
@pkarashchenko sync is ready for review now. |
xiaoxiang781216
approved these changes
Feb 7, 2023
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
pkarashchenko
approved these changes
Feb 7, 2023
xiaoxiang781216
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sync: add sync and syncfs api
Impact
support sync
Testing
Ci