Skip to content

Commit 6a99c09

Browse files
committed
Improved: Remove ‘UtilMisc#toList’
(OFBIZ-11140) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863442 13f79535-47bb-0310-9956-ffa450edef68
1 parent df8586e commit 6a99c09

File tree

3 files changed

+6
-20
lines changed

3 files changed

+6
-20
lines changed

applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -303,12 +303,10 @@ public static List<GenericValue> productOrderByMap(List<GenericValue> values, Ma
303303
return null;
304304
}
305305
if (values.size() == 0) {
306-
return UtilMisc.toList(values);
306+
return values;
307307
}
308308

309-
List<GenericValue> result = new LinkedList<>();
310-
result.addAll(values);
311-
309+
List<GenericValue> result = new LinkedList<>(values);
312310
Collections.sort(result, new ProductByMapComparator(orderByMap, descending));
313311
return result;
314312
}

applications/party/src/main/java/org/apache/ofbiz/party/communication/CommunicationEventServices.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,10 +1169,10 @@ private static void populateAddressesFromMessage(MimeMessageWrapper wrapper, Map
11691169
emailAddressesBCC.add(((InternetAddress) element).getAddress());
11701170
}
11711171
}
1172-
String fromString = StringUtil.join(UtilMisc.toList(emailAddressesFrom), ",");
1173-
String toString = StringUtil.join(UtilMisc.toList(emailAddressesTo), ",");
1174-
String ccString = StringUtil.join(UtilMisc.toList(emailAddressesCC), ",");
1175-
String bccString = StringUtil.join(UtilMisc.toList(emailAddressesBCC), ",");
1172+
String fromString = StringUtil.join(emailAddressesFrom, ",");
1173+
String toString = StringUtil.join(emailAddressesTo, ",");
1174+
String ccString = StringUtil.join(emailAddressesCC, ",");
1175+
String bccString = StringUtil.join(emailAddressesBCC, ",");
11761176

11771177
if (UtilValidate.isNotEmpty(fromString)) {
11781178
commEventMap.put("fromString", fromString);

framework/base/src/main/java/org/apache/ofbiz/base/util/UtilMisc.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -368,18 +368,6 @@ public static <T> List<T> toList(T... data) {
368368
return list;
369369
}
370370

371-
public static <T> List<T> toList(Collection<T> collection) {
372-
if (collection == null) {
373-
return null;
374-
}
375-
if (collection instanceof List<?>) {
376-
return (List<T>) collection;
377-
}
378-
List<T> list = new LinkedList<>();
379-
list.addAll(collection);
380-
return list;
381-
}
382-
383371
public static <T> List<T> toListArray(T[] data) {
384372
if (data == null) {
385373
return null;

0 commit comments

Comments
 (0)