Skip to content

Conversation

mawiesne
Copy link
Contributor

Change

  • adds specific equals and hashCode implementations for TokenizerModel and ParserModel.
  • introduces new test dependency junit-jupiter-params (test-scoped) to opennlp-tools for more flexible test setups.
  • improves TokenizerModelTest, treeinsert.ParserTest and chunking.ParserTest by adding further assertions and fixes TODOs.
  • adds AbstractParserModelTest to avoid code duplication, simplifying existing test cases.
  • adds another Parse example to demonstrate how easy it is to check different examples without duplicating code.
  • removes uncommented code from both ParserTest variants (chunker/treeinsert) by providing actual assertions instead!

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

…rModel

- adds specific `equals` and `hashCode` implementations for `TokenizerModel` and  `ParserModel`.
- introduces new test dependency `junit-jupiter-params` (test-scoped) for opennlp-tools for more flexible test setups.
- improves `TokenizerModelTest`, `treeinsert.ParserTest` and `chunking.ParserTest` by adding further assertions and fixes TODOs.
- adds `AbstractParserModelTest` to avoid code duplication, simplifying existing test cases.
- adds another `Parse` example to demonstrate how easy it is to check different examples without duplicating code.
- removes uncommented code from both `ParserTest` variants (chunker/treeinsert) by providing actual assertions instead!
- addresses review comments by rzo1
@mawiesne mawiesne merged commit 04048f5 into apache:master Dec 19, 2022
@mawiesne mawiesne deleted the OPENNLP-1412_Provide_equals_and_hashCode_for_ParserModel_and_TokenizerModel branch December 19, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants