Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3366. Ozone Client should not retry on invalid token #802

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Skip failover attempts on invalid token (encountered by S3 Gateway), along the lines of #693.

https://issues.apache.org/jira/browse/HDDS-3366

How was this patch tested?

https://github.com/adoroszlai/hadoop-ozone/runs/573315000

Verified that no failover attempt happens, whereas previously client made 15 attempts:

s3g_1 ... ERROR ha.OMFailoverProxyProvider: Failed to connect to OMs: [nodeId=null,nodeAddress=om:9862]. Attempted 15 failovers.
$ grep -c 's3g_1 .* Exception encountered while connecting to the server.*InvalidToken' old new
old:85
new:5

Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bshashikant bshashikant merged commit eb177f4 into apache:master Apr 9, 2020
@bshashikant
Copy link
Contributor

Thanks @adoroszlai for working on this. I have committed this.

@adoroszlai adoroszlai deleted the HDDS-3366 branch April 9, 2020 17:57
@adoroszlai
Copy link
Contributor Author

Thanks @bshashikant and @arp7 for reviewing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants