PHOENIX-6327 Consolidate Junit test categories#1099
Closed
stoty wants to merge 1 commit intoapache:masterfrom
Closed
PHOENIX-6327 Consolidate Junit test categories#1099stoty wants to merge 1 commit intoapache:masterfrom
stoty wants to merge 1 commit intoapache:masterfrom
Conversation
virajjasani
reviewed
Jan 19, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
PR title should also include removal of SplitSystemCatalogTests usage?
| <id>NeedTheirOwnClusterTests</id> | ||
| <configuration> | ||
| <reuseForks>false</reuseForks> | ||
| <argLine>@{jacocoArgLine} -enableassertions -Xmx2000m -XX:MaxPermSize=256m -Djava.security.egd=file:/dev/./urandom "-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}" -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/ -Dorg.apache.hadoop.hbase.shaded.io.netty.packagePrefix=org.apache.hadoop.hbase.shaded.</argLine> |
Contributor
There was a problem hiding this comment.
What was the usage of -Dorg.apache.hadoop.hbase.shaded.io.netty.packagePrefix ?
Contributor
Author
There was a problem hiding this comment.
It was needed for a very short time for shaded netty to find some of its components, but it has long been fixed so that netty can autodetect it.
Contributor
|
I just saw this includes: |
Contributor
Author
|
Actually, I am more inclined to just rename PHOENIX-6327 to something less specifc like "Consolidate IT categories", and close 6328 as a duplicate. |
Contributor
|
Sounds better |
Contributor
Author
|
💔 -1 overall
This message was automatically generated. |
stoty
changed the title
Contributor
|
+1 (non-binding), nice cleanup of the categories! While committing, you might prefer fixing whitespace-eol? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes PHOENIX-6328 Merge SplitSystemCatalogTests test category into NeedTheirOwnClusterTests category