PHOENIX-6298 : Use timestamp of PENDING_DISABLE_COUNT to calculate elapse time for PENDING_DISABLE state#1060
Closed
virajjasani wants to merge 1 commit intoapache:masterfrom
virajjasani:PHOENIX-6298-master
Closed
PHOENIX-6298 : Use timestamp of PENDING_DISABLE_COUNT to calculate elapse time for PENDING_DISABLE state#1060virajjasani wants to merge 1 commit intoapache:masterfrom virajjasani:PHOENIX-6298-master
virajjasani wants to merge 1 commit intoapache:masterfrom
virajjasani:PHOENIX-6298-master
Conversation
Contributor
|
💔 -1 overall
This message was automatically generated. |
gjacoby126
requested changes
Jan 5, 2021
Contributor
gjacoby126
left a comment
gjacoby126
left a comment
There was a problem hiding this comment.
Thanks, @virajjasani . Change looks good, but I think we need a test.
I also want to point out (as I'll do on the JIRA) that this only affects the old indexing framework, because the new one doesn't auto-disable indexes. (It repairs write failures at read time.)
Contributor
Author
|
Thanks for the review @gjacoby126 . Added a test. |
Contributor
|
💔 -1 overall
This message was automatically generated. |
gjacoby126
requested changes
Jan 5, 2021
| final String fullTableName = SchemaUtil.getTableName(schemaName, tableName); | ||
| final String fullIndexName = SchemaUtil.getTableName(schemaName, indexName); | ||
| final MyClock clock = new MyClock(1000); | ||
| EnvironmentEdgeManager.injectEdge(clock); |
Contributor
There was a problem hiding this comment.
We've seen problems in the past with HBase 2.x and injecting an Environment Edge before creating a table. (It can hang forever) Probably want to move the edge injection until after the create table / create index statement unless you know the HBase 2.x edge bug has been fixed, and that it's fixed in all HBase 2.x versions we support (2.1, 2.2, 2.3 and 2.4)
Contributor
Author
There was a problem hiding this comment.
I am not sure if this edge bug is fixed in 2.x versions, so kept the injection after create table.
Thanks
Contributor
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
💔 -1 overall
This message was automatically generated. |
yanxinyi
approved these changes
Jan 9, 2021
…apse time for PENDING_DISABLE state
Contributor
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.