S7szl #287
Closed
S7szl #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM ... only thing I didn't quite understand is why a subscription field has multiple fields inside. |
chrisdutz
approved these changes
Dec 4, 2021
|
I try to resolve the conflicts |
|
ok might be easier to rebase this... Merge was bit hard an I aborted it due to time constraints... |
|
Hello, |
|
no I tried the rebase locally and noticed that it might be easier to rebase the changes onto current develop. Due to timeconstraints I couldn't finish it in time. I try to finish it this weekend. |
This was referenced Jan 28, 2022
|
@glcj I propose to close this PR and you reopen a new one based on a branch in this repo (feature/s7_subscription. There you need to apply your changes manually and we try then to get them merged ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility of: