Skip to content

Pubish Subscribe support for S7#108

Closed
glcj wants to merge 17 commits into
apache:developfrom
glcj:s7alarm
Closed

Pubish Subscribe support for S7#108
glcj wants to merge 17 commits into
apache:developfrom
glcj:s7alarm

Conversation

@glcj
Copy link
Copy Markdown
Contributor

@glcj glcj commented Dec 11, 2019

Hi,

I have tested the connection with an S7-300 (314) + CP 343-1, and I have not been able to make the connection.

When checking with WireShark I found that the dst-tsap and the src-tsap were inverted.

Cheers

@chrisdutz
Copy link
Copy Markdown
Contributor

Hi César, thanks for this great PR ... we'll evaluate this.

Comment thread vim.exe.stackdump Outdated
@@ -0,0 +1,19 @@
Stack trace:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glcj a apache header is missing for this file ;)
https://www.apache.org/legal/src-headers.html

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for the next commit, thanks.

@sruehl sruehl requested a review from chrisdutz December 18, 2019 09:02
@chrisdutz chrisdutz changed the title S7Protocol dst-tsap <-> src-tsap Pubish Subscribe support for S7 Feb 20, 2020
@etiennerobinet
Copy link
Copy Markdown
Contributor

Will this branch be merged? Or is the /develop branch supporting S7 Subscription?

@chrisdutz
Copy link
Copy Markdown
Contributor

No this branch can't be merged as the files it refers to have been deleted ... It's a work in progress which will be converted to mspec and the new generated drivers as soon as it's done.

@chrisdutz
Copy link
Copy Markdown
Contributor

Any progress on bringing this to mspec?

@glcj
Copy link
Copy Markdown
Contributor Author

glcj commented Apr 27, 2020

Any progress on bringing this to mspec?

Hi Chris,

At this moment I am migrating Merlot to use the PLC4X driver model, as soon as I finish I will carry out load tests for the S7 driver, to later migrate to mspec and be in line with the rest of the project.

Work in progress... :-)

@mahendra-korat
Copy link
Copy Markdown

Any progress on this? I need to start trials with my PLCs.

@chrisdutz
Copy link
Copy Markdown
Contributor

I guess Cesar is currently consumed with other work topics ... if this is a high priority requirement for you and your company you could consider contracting someone of the community to work on this (I for my part don't have the necessary hardware ... my S7-1200 doesn't support this form of communication)

@glcj
Copy link
Copy Markdown
Contributor Author

glcj commented Sep 29, 2020

Hello,

The features noted are functional in version 0.6.1 (actually the "s7alarm" branch).

The software is tested for S7-300 & S7-400.

S7-1500 and S7-1200 stations use or do not have a notification system.

By next week I must finish the tests on an S7-400H system, which would transform this version of the driver into the most complete one outside the Siemens ecosystem.

As Chris points out, the next step is to go to the mspec, which is an interesting job, but needs to be funded as you point out.

I will be happy to help you with testing, documenting everything on the PLC4X mailing list.

Best regards,

@sruehl sruehl marked this pull request as draft April 10, 2021 04:58
@sruehl
Copy link
Copy Markdown
Contributor

sruehl commented Jan 28, 2022

superseeded by #287

@sruehl sruehl closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants