Add pathStyleAccess to AwsStorageConfigInfo
#2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
reviewed
Jul 9, 2025
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java
Outdated
Show resolved
Hide resolved
eric-maynard
reviewed
Jul 9, 2025
| } | ||
|
|
||
| public AwsStorageConfigurationInfo( | ||
| @Nonnull StorageType storageType, | ||
| @Nonnull List<String> allowedLocations, | ||
| @Nonnull String roleARN, | ||
| @Nullable String region) { | ||
| this(storageType, allowedLocations, roleARN, null, region, null, null); | ||
| this(storageType, allowedLocations, roleARN, null, region, null, null, false); |
There was a problem hiding this comment.
We could use the default here, or just leave it null to leverage the default used in orElse. Better not to proliferate the constants around like this.
There was a problem hiding this comment.
changed to use PATH_STYLE_ACCESS_DEFAULT
There was a problem hiding this comment.
Now that we have a default at the API level, is this actually nullable?
There was a problem hiding this comment.
I had to remove the API default.
eric-maynard
reviewed
Jul 9, 2025
snazy
previously approved these changes
Jul 9, 2025
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
singhpk234
reviewed
Jul 9, 2025
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java
Outdated
Show resolved
Hide resolved
|
I had to remove one commit (discussed in the API yaml comment thread). PTAL. |
eric-maynard
requested changes
Jul 10, 2025
github-project-automation
bot
moved this from Ready to merge
to PRs In Progress
in Basic Kanban Board
|
@eric-maynard : I believe I addressed your backward-compatibility concern in the latest push. Could you review again? |
dimas-b
force-pushed
the
s3-path-style
branch
2 times, most recently
from
6157bc0 to
85bbabe
Compare
This change allows configuring the "path-style" access mode in S3 clients (both in Polaris Servers and Iceberg REST Catalog API clients). This change is applicable both to AWS storage and to non-AWS S3-compatible storage (apache#1530). The Management API change is backward-compatible.
eric-maynard
previously approved these changes
Jul 16, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
spec/polaris-management-service.yml
Outdated
| type: boolean | ||
| description: >- | ||
| Whether S3 requests to files in this catalog should use 'path-style addressing for buckets'. | ||
| Default: false. |
There was a problem hiding this comment.
nit: With the default in the spec, I don't think we need the default in the doc. Other similar variables don't have it.
snazy
approved these changes
Jul 16, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Jul 17, 2025
adam-christian-software
pushed a commit
to adam-christian-software/polaris
that referenced
this pull request
Jul 18, 2025
* Add `pathStyleAccess` to AwsStorageConfigInfo This change allows configuring the "path-style" access mode in S3 clients (both in Polaris Servers and Iceberg REST Catalog API clients). This change is applicable both to AWS storage and to non-AWS S3-compatible storage (apache#1530).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows configuring the "path-style" access mode in S3 clients (both in Polaris Servers and Iceberg REST Catalog API clients).
This change is applicable both to AWS storage and to non-AWS S3-compatible storage (#1530).
The Management API change is backward-compatible with clients lenient to unknown JSON properties.
Includes a fix to AWS config object round-trip via generated API classes.
Dev ML discussion: https://lists.apache.org/thread/oxy2yd4mbq06zr4z57lfptgy95c3lyhb