Infra: Configure default squash commit message #2016
Conversation
| @@ -33,6 +33,7 @@ github: | |||
| enabled_merge_buttons: | |||
| merge: false | |||
| squash: true | |||
| squash_commit_message: PR_TITLE_AND_DESC | |||
| rebase: false | |||
There was a problem hiding this comment.
Didn't add merge_commit_message: PR_TITLE_AND_DESC as merge is disabled. Only squash is enabled.
ajantha-bhat
requested review from
snazy,
jbonofre and
eric-maynard
and removed request for
snazy
There was a problem hiding this comment.
IMO this deserves a dev-ML discussion first.
TL;DR the current behavior is better, because you get all commit messages in the merge-commit description proposed by GH.
In any way, contributors should review the PR summary and description before opening a PR and committers should really review both the summary and the description of the merge commit, before merging.
|
ok. I will start the discussion. We could have replied the same for the open issue #1656. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
Fixes #1656