Build: Make META-INF/MANIFEST.MF content reproducible #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in apache#2204, some jar manifest attributes prevent having a reproducible build, to eventually be able to generate the _exact_ same artifacts on different systems at different times. Committers shall then be able to re-run the build and compare proposed release artifacts bit-by-bit. This change changes the jar manifest attributes: * `Apache-Polaris-Is-Release` is now also set to `true`, if `-PjarWithGitInfo` is specified * `Apache-Polaris-Build-Git-Describe` is now also generated, if `-PjarWithGitInfo` is specified * `Apache-Polaris-Build-Java-Version` has been removed * `Apache-Polaris-Build-Java-Specification-Version` has been added (it's only the Java major version) * `Apache-Polaris-Build-Timestamp` has been removed * `Apache-Polaris-Build-System` has been removed Contributes to: apache#2204
dimas-b
approved these changes
Aug 21, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2204, some jar manifest attributes prevent having a reproducible build, to eventually be able to generate the exact same artifacts on different systems at different times. Committers shall then be able to re-run the build and compare proposed release artifacts bit-by-bit.
This change changes the jar manifest attributes:
Apache-Polaris-Is-Releaseis now also set totrue, if-PjarWithGitInfois specifiedApache-Polaris-Build-Git-Describeis now also generated, if-PjarWithGitInfois specifiedApache-Polaris-Build-Java-Versionhas been removedApache-Polaris-Build-Java-Specification-Versionhas been added (it's only the Java major version)Apache-Polaris-Build-Timestamphas been removedApache-Polaris-Build-Systemhas been removedContributes to: #2204