Skip to content

Remove PolarisTestMetaStoreManager.jsonNode helper #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

Remove PolarisTestMetaStoreManager.jsonNode helper #2513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 8 additions & 23 deletions ...rc/testFixtures/java/org/apache/polaris/core/persistence/PolarisTestMetaStoreManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@
*/
package org.apache.polaris.core.persistence;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import jakarta.annotation.Nonnull;
import java.util.ArrayList;
import java.util.HashSet;
Expand Down Expand Up @@ -69,7 +66,6 @@ public class PolarisTestMetaStoreManager {

// the start time
private final long testStartTime;
private final ObjectMapper objectMapper = new ObjectMapper();

private final boolean supportsChangeTracking;

Expand Down Expand Up @@ -1515,14 +1511,14 @@ public PolarisBaseEntity updateEntity(
Assertions.assertThat(afterUpdateEntity.getGrantRecordsVersion()).isEqualTo(grantRecsVersion);

// update should have been performed
Assertions.assertThat(jsonNode(updatedEntity.getProperties()))
.isEqualTo(jsonNode(updatedPropEntity.getProperties()));
Assertions.assertThat(jsonNode(afterUpdateEntity.getProperties()))
.isEqualTo(jsonNode(updatedPropEntity.getProperties()));
Assertions.assertThat(jsonNode(updatedEntity.getInternalProperties()))
.isEqualTo(jsonNode(updatedPropEntity.getInternalProperties()));
Assertions.assertThat(jsonNode(afterUpdateEntity.getInternalProperties()))
.isEqualTo(jsonNode(updatedPropEntity.getInternalProperties()));
Assertions.assertThat(updatedEntity.getPropertiesAsMap())
.isEqualTo(updatedPropEntity.getPropertiesAsMap());
Assertions.assertThat(afterUpdateEntity.getPropertiesAsMap())
.isEqualTo(updatedPropEntity.getPropertiesAsMap());
Assertions.assertThat(updatedEntity.getInternalPropertiesAsMap())
.isEqualTo(updatedPropEntity.getInternalPropertiesAsMap());
Assertions.assertThat(afterUpdateEntity.getInternalPropertiesAsMap())
.isEqualTo(updatedPropEntity.getInternalPropertiesAsMap());

// lookup the tracking slice to verify this has been updated too
if (supportsChangeTracking) {
Expand All @@ -1542,17 +1538,6 @@ public PolarisBaseEntity updateEntity(
return updatedEntity;
}

private JsonNode jsonNode(String json) {
if (json == null) {
return null;
}
try {
return objectMapper.readTree(json);
} catch (JsonProcessingException e) {
throw new RuntimeException(e);
}
}

/** Execute a list operation and validate the result */
private void validateListReturn(
List<PolarisEntityCore> path,
Expand Down