Use AssertJ assertions in tests #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
changed the title
fivetran-kostaszoumpatianos
pushed a commit
to fivetran/polaris
that referenced
this pull request
Jun 18, 2025
fabio-rizzo-01
pushed a commit
to fabio-rizzo-01/polaris
that referenced
this pull request
Jun 20, 2025
# This is the 1st commit message: apache#772 fixed integration tests and synched with main Mypy did a new release 1.16.1 and it cause our CI to fail for about 20 minutes due to missing wheel (upload not completed) ``` | Unable to find installation candidates for mypy (1.16.1) | | This is likely not a Poetry issue. | | - 14 candidate(s) were identified for the package | - 14 wheel(s) were skipped as your project's environment does not support the identified abi tags | | Solutions: | Make sure the lockfile is up-to-date. You can try one of the following; | | 1. Regenerate lockfile: poetry lock --no-cache --regenerate | 2. Update package : poetry update --no-cache mypy | | If neither works, please first check to verify that the mypy has published wheels available from your configured source that are compatible with your environment- ie. operating system, architecture (x86_64, arm64 etc.), python interpreter. | ``` This PR temporarily restrict the mypy version to avoid the similar issue. We may consider bring poetry.lock back to git tracking so we won't automatically update test dependencies all the time # This is the commit message apache#48: Remove `.github/CODEOWNERS` (apache#1902) As per this [dev-ML discussion](https://lists.apache.org/thread/jjr5w3hslk755yvxy8b3z45c7094cxdn) # This is the commit message apache#49: Rename quarkus as runtime (apache#1695) # This is the commit message apache#50: parent 3185adf author Mend Renovate <bot@renovateapp.com> 1749165686 +0200 committer Rizzo Cascio, Fabio <fabio.rizzocascio@jpmorgan.com> 1749646499 +0100 # This is a combination of 2 commits. # This is the 1st commit message: Mutable objects used for immutable values apache#772: resolved conflicts # This is the commit message apache#51: Mutable objects used for immutable values apache#772: fixed integration tests # This is the commit message apache#52: parent 3185adf author Mend Renovate <bot@renovateapp.com> 1749165686 +0200 committer Rizzo Cascio, Fabio <fabio.rizzocascio@jpmorgan.com> 1749646499 +0100 # This is a combination of 2 commits. # This is the 1st commit message: Mutable objects used for immutable values apache#772: resolved conflicts Mutable objects used for immutable values apache#772: added final to base and core fields Mutable objects used for immutable values apache#772: fixed tests
travis-bowen
pushed a commit
to travis-bowen/polaris
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PolarisObjectMapperUtilTest already uses AssertJ.
AssertJ provides more helpful messages than JUnit when failed.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.