-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default retry and dlq topic name fixed as per the doc #891
Conversation
@nodece how retry mechnism works for partition topics does it create seprate retry topic for each partitions? same applies to dlq? |
I think it's the same, it should be based on the namespace with the subscription name. |
@RobertIndie or @nodece any idea when this can be merged |
@ngoyal16 Could you rebase your code? |
default retry and dlq name fixed based on doc
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@nodece rebase done |
Motivation
In Apache pulsar documention default retry and dlq topic names are as follows
for Retry:
<topicname>-<subscriptionname>-RETRY
https://pulsar.apache.org/docs/2.10.x/concepts-messaging#retry-letter-topic
for DLQ:
<topicname>-<subscriptionname>-DLQ
https://pulsar.apache.org/docs/2.10.x/concepts-messaging#dead-letter-topic
Modifications
added topicname also in the default Retry and DLQ topic name
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation