Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default retry and dlq topic name fixed as per the doc #891

Merged
merged 11 commits into from
Dec 18, 2022

Conversation

ngoyal16
Copy link
Contributor

@ngoyal16 ngoyal16 commented Nov 18, 2022

Motivation

In Apache pulsar documention default retry and dlq topic names are as follows

for Retry: <topicname>-<subscriptionname>-RETRY
https://pulsar.apache.org/docs/2.10.x/concepts-messaging#retry-letter-topic
for DLQ: <topicname>-<subscriptionname>-DLQ
https://pulsar.apache.org/docs/2.10.x/concepts-messaging#dead-letter-topic

Modifications

added topicname also in the default Retry and DLQ topic name

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

pulsar/consumer_impl.go Outdated Show resolved Hide resolved
@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Nov 24, 2022

@nodece how retry mechnism works for partition topics

does it create seprate retry topic for each partitions? same applies to dlq?

@nodece
Copy link
Member

nodece commented Nov 29, 2022

@nodece how retry mechnism works for partition topics

does it create seprate retry topic for each partitions? same applies to dlq?

I think it's the same, it should be based on the namespace with the subscription name.

@ngoyal16
Copy link
Contributor Author

@RobertIndie or @nodece any idea when this can be merged

@nodece
Copy link
Member

nodece commented Dec 16, 2022

@ngoyal16 Could you rebase your code?

default retry and dlq name fixed based on doc
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
Copy link
Contributor Author

@nodece rebase done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants