Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CustomProperties when sending message for retry #916

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

ngoyal16
Copy link
Contributor

@ngoyal16 ngoyal16 commented Dec 19, 2022

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #915

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #915

Motivation

In Java SDK custom properties are allowed when ReconsumeLater is called so adding same in golang

Modifications

Created a function which will take custom message properties and add them to retry message as per the doc.
To reduce the same code i callback this function from the reconsume later function. because other part of the code is same execpt the one which should change.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: may be, added another public function for consumer to allow custom properties
  • The schema: (yes / no / don't know)
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to verify it?

Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
Copy link
Contributor Author

@RobertIndie test case added for RLQ with custom properties

@nodece nodece merged commit 1f3747e into apache:master Jan 3, 2023
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow CustomProperties when calling ReconsumeLater
3 participants