Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Cobra library to significantly reduce the dependency tree #943

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Update the Cobra library to significantly reduce the dependency tree #943

merged 1 commit into from
Jan 17, 2023

Conversation

reugn
Copy link
Contributor

@reugn reugn commented Jan 14, 2023 •
edited
Loading

Motivation

As of v1.4.0, the core Cobra library no longer requires Viper and all of its indirect dependencies. This greatly reduces the overall dependency tree.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a dependency update without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@nodece nodece merged commit d9b18d0 into apache:master Jan 17, 2023
@reugn reugn deleted the update-cobra branch January 21, 2023 12:56
@RobertIndie RobertIndie added this to the v0.10.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibd shibd shibd approved these changes

@nodece nodece nodece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@reugn @nodece @shibd @RobertIndie