[perf] Support batch index ACK and max number of messages in batch #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation Currently, the perf tool does not support the maximum number of messages in batch for producer and batch index ACK for consumer. ### Modifications - Add the `--batching-max-size` option to configure the maximum number of messages for producer - To keep the code style consistent, change the `--batching-max-size` config from `int` to `uint` - Add the `--enable-batch-index-ack` option to enable batch index ACK for consumer.
BewareMyPower
requested review from
cckellogg,
nodece,
RobertIndie,
shibd and
wolfstudy
shibd
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the perf tool does not support the maximum number of messages in batch for producer and batch index ACK for consumer.
Modifications
--batching-max-sizeoption to configure the maximum number of messages for producer--batching-max-sizeconfig frominttouint--enable-batch-index-ackoption to enable batch index ACK for consumer.