Skip to content

Issue #37 : Allow passing pulsar.MessageId instance to create_reader() #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Issue #37 : Allow passing pulsar.MessageId instance to create_reader() #95

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeb7f12
Issue #37 : Allow passing pulsar.MessageId instance to create_reader()
erichare Feb 15, 2023
3355d31
Update __init__.py
erichare Feb 15, 2023
2bd9819
Remove unneeded import
erichare Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pulsar/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,11 @@ def my_listener(reader, message):
Symmetric encryption class implementation, configuring public key encryption messages for the producer
and private key decryption messages for the consumer
"""

# If a pulsar.MessageId object is passed, access the _pulsar.MessageId object
if isinstance(start_message_id, MessageId):
start_message_id = start_message_id._msg_id

_check_type(str, topic, 'topic')
_check_type(_pulsar.MessageId, start_message_id, 'start_message_id')
_check_type(_schema.Schema, schema, 'schema')
Expand Down