Avoid to infinitely split bundle #11937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
release/2.8.2
type/enhancement
eolivelli
reviewed
Sep 7, 2021
First, It's not a config like One namespace, one topic/partition, but the topic's rate is high, the bundle split will infinitely splite bundle, make this topic doesn't work. |
And it's meaningless for split bundle that has only one topic |
|
why bundle contains one topic cannot split? I am confused. |
Cause it will lead to infinitely split bundle. |
|
Good catch @shoothzj ! |
lhotari
approved these changes
Sep 7, 2021
codelipenghui
approved these changes
Sep 8, 2021
merlimat
approved these changes
Sep 8, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 9, 2021
(cherry picked from commit bef3757)
1 task
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If there is just one topic, but reached the split conditition. The pulsar broker will went to infinitely splitting bundle.
Modifications
If there is just one topic, we do not split.
Documentation
It's an internal change, no need doc