Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The count of topics on the bundle is less than 2，skip split #12527

Merged
merged 1 commit into from
Nov 1, 2021
Merged

The count of topics on the bundle is less than 2，skip split #12527

merged 1 commit into from
Nov 1, 2021

Conversation

lordcheng10
Copy link
Contributor

@lordcheng10 lordcheng10 commented Oct 29, 2021 •
edited
Loading

Motivation

The count of topics on the bundle is less than 2，skip split

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java

Lines 75 to 78 in 52dffda

if (stats.topics == 1) {
log.info("namespace bundle {} only have 1 topic", bundle);
continue;
}

Documentation

  • no-need-doc

It's an internal change, no need doc

@github-actions
Copy link

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@lordcheng10
Copy link
Contributor Author

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

It's an internal change, no need doc

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@shoothzj
Copy link
Member

Can this topics equal to zero?

@lordcheng10
Copy link
Contributor Author

lordcheng10 commented Oct 29, 2021 •
edited
Loading

Can this topics equal to zero?

Topic and bundle are mapped through hash, so I understand that there may be no topic in a bundle

Jason918
Jason918 approved these changes Oct 30, 2021
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

lhotari
lhotari approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
Copy link
Member

lhotari commented Oct 30, 2021

This is an improvement to #11937 changes. Just adding the link for cross-reference.

@lhotari lhotari added doc-not-needed Your PR changes do not impact docs area/broker type/bug The PR fixed a bug or issue reported a bug and removed doc-label-missing labels Oct 30, 2021
@lhotari lhotari added this to the 2.10.0 milestone Oct 30, 2021
@315157973 315157973 merged commit 384c5dc into apache:master Nov 1, 2021
hangc0276 pushed a commit that referenced this pull request Nov 4, 2021
@lordcheng10 @hangc0276
The count of topics on the bundle is less than 2，skip split (#12527)
5bf746c 
The count of topics on the bundle is less than 2，skip split

(cherry picked from commit 384c5dc)
@hangc0276 hangc0276 added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Nov 4, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@lordcheng10 @eolivelli
The count of topics on the bundle is less than 2，skip split (apache#1…
3a89c8a 
…2527)

The count of topics on the bundle is less than 2，skip split
lhotari pushed a commit to datastax/pulsar that referenced this pull request Dec 3, 2021
@lordcheng10 @lhotari
The count of topics on the bundle is less than 2，skip split (apache#1…
8fe8c3f 
…2527)

The count of topics on the bundle is less than 2，skip split

(cherry picked from commit 384c5dc)
(cherry picked from commit 5bf746c)
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@lordcheng10 @codelipenghui
The count of topics on the bundle is less than 2，skip split (#12527)
f769226 
The count of topics on the bundle is less than 2，skip split

(cherry picked from commit 384c5dc)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

@Jason918 Jason918 Jason918 approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@eolivelli eolivelli Awaiting requested review from eolivelli

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@lordcheng10 lordcheng10

Labels
area/broker cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lordcheng10 @shoothzj @lhotari @Jason918 @hangc0276 @eolivelli @315157973 @codelipenghui