[Admin] Get schema validation enforce add applied. #12349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
hangc0276,
eolivelli,
315157973,
codelipenghui,
gaoran10,
wolfstudy,
zymap,
sijie and
merlimat
yuruguo
requested changes
Oct 14, 2021
| @@ -1626,9 +1626,10 @@ public void setSubscriptionTypesEnabled( | |||
| @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"), | |||
| @ApiResponse(code = 404, message = "Tenants or Namespace doesn't exist") }) | |||
| public boolean getSchemaValidtionEnforced(@PathParam("tenant") String tenant, | |||
| @PathParam("namespace") String namespace) { | |||
| @PathParam("namespace") String namespace, | |||
| @QueryParam("applied") boolean applied) { | |||
There was a problem hiding this comment.
We should give a default value, as below:
@QueryParam("applied") @DefaultValue("false") boolean applied
Anonymitaet
added
the
doc
yuruguo
approved these changes
Oct 14, 2021
| @@ -3547,16 +3548,41 @@ void setSchemaAutoUpdateCompatibilityStrategy(String namespace, | |||
| * @throws PulsarAdminException | |||
| * Unexpected error | |||
| */ | |||
| boolean getSchemaValidationEnforced(String namespace) | |||
| throws PulsarAdminException; | |||
| @Deprecated | |||
There was a problem hiding this comment.
We should not deprecate this API right?
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
* up/master: [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
….2-chapter-4 * website/branch-2.7.2-chapter-3: Update the nesting of forms in the document [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
codelipenghui
pushed a commit
that referenced
this pull request
Oct 21, 2021
now, namespace get schema validation enforce don't return broker config, if namespace policy the schema validation enforce is false and we use --applied, we should return this config in broker level. (cherry picked from commit 69fb802)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
now, namespace get schema validation enforce don't return broker config, if namespace policy the schema validation enforce is false and we use --applied, we should return this config in broker level. (cherry picked from commit 69fb802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
now, namespace get schema validation enforce don't return broker config, if namespace policy the schema validation enforce is false and we use --applied, we should return this config in broker level.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (yes)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)