Fix java doc for MultipleListenerValidator #12389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
EronWright
suggested changes
Oct 15, 2021
Comment on lines
42
to
45
| * 1. the listener name in `advertisedListeners` must not duplicate. | ||
| * 2. user can not assign same 'host:port' to different listener. | ||
| * 3. if `internalListenerName` is absent, the first `listener` in the `advertisedListeners` will be the `internalListenerName`. | ||
| * 4. if pulsar do not specify `brokerServicePortTls`, should only contain one entry of `pulsar://` per listener name. |
There was a problem hiding this comment.
Note that (4) is obsolete.
May I suggest:
advertisedListenersconsists of a comma-separated list of endpoints.- Each endpoint consists of a listener name and an associated address (
listener:scheme://host:port). - A listener name may be repeated to define both a non-TLS and a TLS endpoint.
- Duplicate definitions are disallowed.
- If
internalListenerNameis absent, set it to the first listener defined inadvertisedListeners.
There was a problem hiding this comment.
Sorry for not updating the content of the document. Thanks @EronWright for your suggestion. I fixed it. PTAL. Thanks.
eolivelli
approved these changes
Oct 16, 2021
EronWright
approved these changes
Oct 16, 2021
|
Thanks @eolivelli @EronWright for your review. |
codelipenghui
approved these changes
Oct 18, 2021
|
Thanks @codelipenghui for your review and merge. |
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
* up/master: [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
….2-chapter-4 * website/branch-2.7.2-chapter-3: Update the nesting of forms in the document [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
### Motivation *Fix the java doc mentioned in [#12353](https://github.com/apache/pulsar/pull/12353/files#r729887373)* ### Modifications *Fix java doc for MultipleListenerValidator#validateAndAnalysisAdvertisedListener.* (cherry picked from commit 9d10b8b)
gaoran10
added
the
doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the java doc mentioned in #12353
Modifications
Fix java doc for MultipleListenerValidator#validateAndAnalysisAdvertisedListener.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?