[Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. #12376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
eolivelli,
congbobo184,
codelipenghui and
gaoran10
congbobo184
approved these changes
Oct 18, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Oct 19, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
* up/master: [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Oct 20, 2021
….2-chapter-4 * website/branch-2.7.2-chapter-3: Update the nesting of forms in the document [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170) Allow to config pulsar client allocator out of memory policy (apache#12200) [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. (apache#12376) Bumped version to 2.10.0-SNAPSHOT (apache#12285) [docs][Website] add docs of broker entry metadata (apache#12404) [C++] Use weak ref to ClientConnection for timeout task (apache#12409) fix windows test path probleam (apache#12398) [website][upgrade]feat: home page (apache#12383) [docs] [ISSUE 11526] Update the description of `topic` (apache#12375) [Docs] Add document label check robot (apache#12371) [Admin] Get schema validation enforce add applied. (apache#12349) [Doc] add scope explanations (apache#12380) Fix java doc for MultipleListenerValidator (apache#12389)
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…st be ManagedLedgerException. (apache#12376) Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException. So we handle this in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException.
So we handle this in
Modifications
After the method call ends exceptionally, wrap the exception as ManagerLedgerException in exceptionally{}.
Verifying this change
Add a test in transactionTest
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
This is a Bug Fix
doc
(If this PR contains doc changes)