Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Use weak ref to ClientConnection for timeout task #12409

Merged
merged 2 commits into from
Oct 19, 2021
Merged

[C++] Use weak ref to ClientConnection for timeout task #12409

merged 2 commits into from
Oct 19, 2021

Conversation

merlimat
Copy link
Contributor

Motivation

Fixes #12408. Using a weak reference in the timeout task for ClientConnection to break a circular reference dependency between the connection instance and the task.

@merlimat merlimat added type/bug The PR fixed a bug or issue reported a bug release/2.8.2 release/2.9.1 labels Oct 18, 2021
@merlimat merlimat added this to the 2.10.0 milestone Oct 18, 2021
@merlimat merlimat self-assigned this Oct 18, 2021
@eolivelli
Copy link
Contributor

@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli
Copy link
Contributor

@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

2 similar comments
@eolivelli
Copy link
Contributor

@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli
Copy link
Contributor

@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@merlimat merlimat added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Oct 18, 2021
@BewareMyPower BewareMyPower merged commit 4e43a1d into apache:master Oct 19, 2021
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 20, 2021
Merge branch 'up/master' into website/branch-2.7.2-chapter-3
88ac2a0 
* up/master:
  [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170)
  Allow to config pulsar client allocator out of memory policy (apache#12200)
  [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException.  (apache#12376)
  Bumped version to 2.10.0-SNAPSHOT (apache#12285)
  [docs][Website] add docs of broker entry metadata (apache#12404)
  [C++] Use weak ref to ClientConnection for timeout task (apache#12409)
  fix windows test path probleam (apache#12398)
  [website][upgrade]feat: home page (apache#12383)
  [docs] [ISSUE 11526] Update the description of `topic` (apache#12375)
  [Docs] Add document label check robot (apache#12371)
  [Admin] Get schema validation enforce add applied. (apache#12349)
  [Doc] add scope explanations (apache#12380)
  Fix java doc for MultipleListenerValidator (apache#12389)
zeo1995 pushed a commit to zeo1995/pulsar that referenced this pull request Oct 20, 2021
Merge branch 'website/branch-2.7.2-chapter-3' into website/branch-2.7…
987d7e8 
….2-chapter-4

* website/branch-2.7.2-chapter-3:
  Update the nesting of forms in the document
  [pulsar-java-client] Auto-recovery after exception like out of direct memory (apache#12170)
  Allow to config pulsar client allocator out of memory policy (apache#12200)
  [Transaction] Fix bugs, Exception thrower by TB::appendBufferToTxn must be ManagedLedgerException.  (apache#12376)
  Bumped version to 2.10.0-SNAPSHOT (apache#12285)
  [docs][Website] add docs of broker entry metadata (apache#12404)
  [C++] Use weak ref to ClientConnection for timeout task (apache#12409)
  fix windows test path probleam (apache#12398)
  [website][upgrade]feat: home page (apache#12383)
  [docs] [ISSUE 11526] Update the description of `topic` (apache#12375)
  [Docs] Add document label check robot (apache#12371)
  [Admin] Get schema validation enforce add applied. (apache#12349)
  [Doc] add scope explanations (apache#12380)
  Fix java doc for MultipleListenerValidator (apache#12389)
codelipenghui pushed a commit that referenced this pull request Oct 21, 2021
@merlimat @codelipenghui
[C++] Use weak ref to ClientConnection for timeout task (#12409)
d126723 
### Motivation

Fixes #12408. Using a weak reference in the timeout task for `ClientConnection` to break a circular reference dependency between the connection instance and the task.

(cherry picked from commit 4e43a1d)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 21, 2021
@merlimat merlimat mentioned this pull request Nov 4, 2021
Closed
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@merlimat @codelipenghui
[C++] Use weak ref to ClientConnection for timeout task (#12409)
2c364d9 
### Motivation

Fixes #12408. Using a weak reference in the timeout task for `ClientConnection` to break a circular reference dependency between the connection instance and the task.

(cherry picked from commit 4e43a1d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

Assignees

@merlimat merlimat

Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Python Pulsar client creates producer and then close producer, the memory will not be freed
5 participants
@merlimat @eolivelli @BewareMyPower @codelipenghui @gaoran10