Skip to content

Conversation

mehrdad-hassanabadi
Copy link

Motivation

Currently Pulsar functions using Context have access to PulsarAdmin client instance. By moving the getPulsarAdmin method from Context to the parent interface BaseContext we can provide the same access to source and sink functions as well. This would provide sources and sinks access to topic stats in order for them to make decisions with regards to scale and load handling, throttling, etc.

Modifications

The getPulsarAdmin method from Context to the parent interface BaseContext.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as ContextImplTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • no-need-doc
    The method already has Javadoc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 16, 2022
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jun 16, 2022
@tisonkun
Copy link
Member

Closed as stale. Please rebase and resubmit the patch if it's still relevant.

@tisonkun tisonkun closed this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants