[fix][broker] Fix incorrect unack msk count when dup ack a message #20990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
changed the title
codelipenghui
approved these changes
Aug 15, 2023
BewareMyPower
approved these changes
Aug 15, 2023
congbobo184
reviewed
Aug 15, 2023
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #20990 +/- ##
============================================
+ Coverage 36.92% 36.95% +0.02%
- Complexity 12187 12229 +42
============================================
Files 1698 1698
Lines 129846 129857 +11
Branches 14163 14163
============================================
+ Hits 47947 47986 +39
+ Misses 75570 75548 -22
+ Partials 6329 6323 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
added a commit
that referenced
this pull request
Aug 21, 2023
Technoboy-
added a commit
that referenced
this pull request
Aug 21, 2023
|
@Technoboy- Can you help create a PR to cherry-pick this change to |
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 25, 2023
…pache#20990) (cherry picked from commit 4facdad)
15 tasks
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jan 11, 2024
…pache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
4 tasks
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Jan 16, 2024
* [fix][broker] Fix incorrect unack msk count when dup ack a message (apache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix][test] flaky test `testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Co-authored-by: Jiwei Guo <technoboy@apache.org> Co-authored-by: labuladong <labuladong@foxmail.com>
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 8, 2024
…pache#20990) (cherry picked from commit 4facdad)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 8, 2024
…pache#20990) (cherry picked from commit 4facdad)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 8, 2024
…pache#20990) (cherry picked from commit 4facdad)
15 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Mar 14, 2024
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 15, 2024
* [fix][broker] Fix incorrect unack msk count when dup ack a message (apache#20990) (cherry picked from commit 4facdad) Signed-off-by: Zixuan Liu <nodeces@gmail.com> * [fix][test] flaky test `testCanRecoverConsumptionWhenLiftMaxUnAckedMessagesRestriction` (apache#18726) (cherry picked from commit 2d205c9) Signed-off-by: Zixuan Liu <nodeces@gmail.com> --------- Co-authored-by: Jiwei Guo <technoboy@apache.org> Co-authored-by: labuladong <labuladong@foxmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19268
Modifications
When pendingAck not contains the message, it means the msg has been removed, so it can't update the unack msg count..
Documentation
docdoc-requireddoc-not-neededdoc-complete