[fix] [test] Fix flaky test ManagedLedgerTest.testGetNumberOfEntriesInStorage #22344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
reviewed
Mar 26, 2024
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
Show resolved
Hide resolved
nodece
approved these changes
Mar 26, 2024
dao-jun
approved these changes
Mar 27, 2024
lhotari
approved these changes
Mar 27, 2024
Merged
15 tasks
This was referenced Mar 27, 2024
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…nStorage (apache#22344) (cherry picked from commit fc066d7) (cherry picked from commit 100a53b)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…nStorage (apache#22344) (cherry picked from commit fc066d7) (cherry picked from commit 100a53b)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…nStorage (apache#22344) (cherry picked from commit fc066d7) (cherry picked from commit 100a53b)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…nStorage (apache#22344) (cherry picked from commit fc066d7) (cherry picked from commit 100a53b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…nStorage (apache#22344) (cherry picked from commit fc066d7) (cherry picked from commit 100a53b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Flaky test logs
https://github.com/apache/pulsar/actions/runs/8416664128/job/23064867159?pr=22283
Issue
testGetNumberOfEntriesInStorageforce setML.statetoLedgerOpened,which breaks the mechanism to guarantee no concurrent ledger switching. This leads to an unexpected emptyledgerInfoin the ledger list.[{id: 1, entries: 5}, {id: 2, entries: 5}, {id: 3, entries:0}][{id: 1, entries: 5}, {id: 2, entries: 5}, {id: 3, entries:0}, {id: 4, entries:0}]Reproduce
You can reproduce the flaky test by running it about 10 times.
Modifications
Remove the unnecessary ledger switching.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x