-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix geo-replication admin client url #22584
Merged
nodece
merged 3 commits into
apache:master
from
Demogorgon314:Demogorgon314/fix-geo-replication-admin-url
May 9, 2024
Merged
[fix][broker] Fix geo-replication admin client url #22584
nodece
merged 3 commits into
apache:master
from
Demogorgon314:Demogorgon314/fix-geo-replication-admin-url
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Apr 28, 2024
hanmz
approved these changes
Apr 30, 2024
Coselding
approved these changes
May 6, 2024
Demogorgon314
force-pushed
the
Demogorgon314/fix-geo-replication-admin-url
branch
from
May 8, 2024 12:15
7deccc7
to
f2a5af4
Compare
dao-jun
approved these changes
May 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22584 +/- ##
============================================
- Coverage 73.57% 73.13% -0.45%
- Complexity 32624 32772 +148
============================================
Files 1877 1887 +10
Lines 139502 141073 +1571
Branches 15299 15484 +185
============================================
+ Hits 102638 103168 +530
- Misses 28908 29949 +1041
Partials 7956 7956
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nodece
approved these changes
May 9, 2024
poorbarcode
pushed a commit
that referenced
this pull request
Jul 13, 2024
(cherry picked from commit bd4c57d)
poorbarcode
pushed a commit
that referenced
this pull request
Jul 13, 2024
(cherry picked from commit bd4c57d)
poorbarcode
pushed a commit
that referenced
this pull request
Jul 13, 2024
(cherry picked from commit bd4c57d)
nodece
pushed a commit
that referenced
this pull request
Jul 23, 2024
(cherry picked from commit bd4c57d)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit bd4c57d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we only set the TLS URLs for
ClusterData
and set thebrokerClientTlsEnabled
totrue
, the admin client for geo-replication will be failed to create because the else if block(StringUtils.isEmpty(data.getServiceUrl())
) logic is wrong.Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete