-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Disable JFR metric reporting in OpenTelemetry #22669
[improve][broker] Disable JFR metric reporting in OpenTelemetry #22669
Conversation
…runtime memory leak
…ip-264-java-runtime-metrics
… issues caused by TestNG memory leaks
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22669 +/- ##
============================================
- Coverage 73.57% 72.72% -0.86%
+ Complexity 32624 32344 -280
============================================
Files 1877 1887 +10
Lines 139502 141060 +1558
Branches 15299 15481 +182
============================================
- Hits 102638 102580 -58
- Misses 28908 30616 +1708
+ Partials 7956 7864 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@dragosvictor I checked the source code of io.opentelemetry.instrumentation.runtimemetrics.java17.RuntimeMetricsBuilder and io.opentelemetry.instrumentation.runtimemetrics.java17.JfrFeature . It seems that some features are enabled by default. |
Motivation
Metrics related to JFR are not currently supported by Pulsar, let's disable their reporting until this is needed.
Modifications
Trivial disablement of the metrics.
Verifying this change
This change is already covered by existing tests, such as
org.apache.pulsar.opentelemetry.OpenTelemetryServiceTest#testJvmRuntimeMetrics
.Does this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dragosvictor#23