QPID-8637: add Containerfile based on CentOS Stream 9 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
force-pushed
the
jd_2023_04_15_container
branch
5 times, most recently
from
169b35a
to
b5422b6
Compare
gemmellr
reviewed
Apr 17, 2023
Comment on lines
+42
to
+46
| # Workaround for latest release of qpid-python being incompatible with python 3 | ||
| WORKDIR /build | ||
| RUN git clone https://github.com/apache/qpid-python.git \ | ||
| && cd qpid-python \ | ||
| && python3 setup.py install |
There was a problem hiding this comment.
Its fine to do this in a file aimed at e.g qpid-cpp developers building the latest code, but a 'normal' file aimed at regular users shouldnt be doing it as we need to point everyday users to released versions.
This file looks to be of the former developer variety, but is more named and [not] documented as the normal user variety....it should be updated to be consistently one of the other.
There was a problem hiding this comment.
True. Currently this is something that wants to be user-centric, but it cannot be, for several reasons, this being one of them.
I'm going to leave the PR open until there is released qpid-python that I can use here.
jiridanek
force-pushed
the
jd_2023_04_15_container
branch
from
b5422b6
to
07e79bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.