This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-68] Make Wake unit tests robust to port conflicts #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EunhyangKim Thanks for the PR. I will take a look. |
| localAddressProvider, Tang.Factory.getTang().newInjector().getInstance(TcpPortProvider.class)); | ||
|
|
||
| final RemoteIdentifierFactory factory = new DefaultRemoteIdentifierFactoryImplementation(); | ||
| final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + PORT); | ||
| final int port = rm.getListeningPort(); | ||
| final RemoteIdentifier remoteId = factory.getNewInstance("socket://" + hostAddress + ":" + port); |
There was a problem hiding this comment.
You can use getMyIdentifier(): remoteId = rm.getMyIdentifier()
|
@EunhyangKim I did a pass. Could you please take a look at them and fix your code? Thanks! |
This addressed the issue by * Giving 0 for port numbers which leads to using random numbers as port numbers, * Getting port numbers with getListeningPort() for reuse. * Using getMyIdentifer() to directly get remote identifiers. JIRA: [REEF-68](https://issues.apache.org/jira/browse/REEF-68)
|
@taegeonum |
|
Looks good to me! I'm merging it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addressed the issue by
JIRA:
REEF-68