Skip to content

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

#74 Add acl examples compile in the project

Brief changelog

Add acl examples compile in the project

Verifying this change

mvn compile

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added this to the 2.0.4 milestone May 24, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label May 24, 2019
@ShannonDing ShannonDing merged commit 0110055 into apache:master May 25, 2019
@ShannonDing ShannonDing modified the milestones: 2.0.4, 2.0.3 May 31, 2019
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this pull request Mar 26, 2020
* Fix checkstyle error in the acl examples

* Add acl example compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant