Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5390] not to print some useless log in PopReviveService #5391

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented Oct 24, 2022

Make sure set the target branch to develop

What is the purpose of the change

close #5390

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

lollipopjin
lollipopjin previously approved these changes Oct 24, 2022
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lizhimins
lizhimins previously approved these changes Oct 24, 2022
nowinkeyy
nowinkeyy previously approved these changes Oct 24, 2022
RongtongJin
RongtongJin previously approved these changes Oct 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5391 (cb60377) into develop (e863f48) will decrease coverage by 0.12%.
The diff coverage is 36.25%.

@@              Coverage Diff              @@
##             develop    #5391      +/-   ##
=============================================
- Coverage      43.24%   43.11%   -0.13%     
- Complexity      7881     7991     +110     
=============================================
  Files           1006     1016      +10     
  Lines          70046    71499    +1453     
  Branches        9259     9463     +204     
=============================================
+ Hits           30290    30829     +539     
- Misses         35963    36784     +821     
- Partials        3793     3886      +93     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 46.71% <0.00%> (+2.84%) ⬆️
...rocketmq/broker/processor/AckMessageProcessor.java 44.64% <0.00%> (-0.41%) ⬇️
...broker/processor/ChangeInvisibleTimeProcessor.java 56.58% <0.00%> (-10.39%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 38.03% <0.00%> (-0.14%) ⬇️
...he/rocketmq/broker/processor/PopReviveService.java 36.14% <0.00%> (-1.59%) ⬇️
.../transaction/queue/TransactionalMessageBridge.java 74.03% <0.00%> (-2.54%) ⬇️
...apache/rocketmq/common/message/MessageDecoder.java 62.70% <ø> (ø)
...ache/rocketmq/common/utils/CleanupPolicyUtils.java 0.00% <0.00%> (ø)
...va/org/apache/rocketmq/namesrv/NamesrvStartup.java 15.83% <0.00%> (-0.14%) ⬇️
...org/apache/rocketmq/store/AppendMessageResult.java 63.63% <0.00%> (-3.04%) ⬇️
... and 50 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xdkxlk xdkxlk merged commit 40013b3 into apache:develop Oct 25, 2022
@xdkxlk xdkxlk deleted the develop-pop-log branch October 25, 2022 02:10
Focus-rth added a commit to Focus-rth/rocketmq that referenced this pull request Oct 25, 2022
* develop:
  [ISSUE apache#5390] not to print some useless log in PopReviveService (apache#5391)
  Fix the issue that TransactionMessageIT can not pass (apache#5394)
  [ISSUE apache#5373] output namesrv bindaddress when starting (apache#5369)
  [ISSUE apache#5381] Optimize merge_rocketmq_pr.py comments (apache#5389)
  [ISSUE apache#3799]main compaction process (apache#5351)
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are to many useless log in pop.log
8 participants