Skip to content

Conversation

@labazhou2018
Copy link
Contributor

@labazhou2018 labazhou2018 commented Oct 24, 2022

Make sure set the target branch to develop

What is the purpose of the change

[ISSUE #5381 ] Optimize merge_rocketmq_pr.py comments in develop branch

Fixes #5381

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@lizhimins lizhimins merged commit 865d704 into apache:develop Oct 24, 2022
Focus-rth added a commit to Focus-rth/rocketmq that referenced this pull request Oct 25, 2022
* develop:
  [ISSUE apache#5390] not to print some useless log in PopReviveService (apache#5391)
  Fix the issue that TransactionMessageIT can not pass (apache#5394)
  [ISSUE apache#5373] output namesrv bindaddress when starting (apache#5369)
  [ISSUE apache#5381] Optimize merge_rocketmq_pr.py comments (apache#5389)
  [ISSUE apache#3799]main compaction process (apache#5351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize Python scripts comments

2 participants