Skip to content

Small Code Optimizations + Dependency Updates #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 23, 2021
Merged

Small Code Optimizations + Dependency Updates #105

merged 12 commits into from
Oct 23, 2021

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 2, 2021

a set of refactorings for better performance or more concise / easier to read code + minor version dependency updates

most of it was done by using the jackpot code inspection rules found here:
https://github.com/mbien/jackpot-inspections

mbien added 12 commits October 1, 2021 22:49
@mbien
Use getDeviceType() of the already parsed request instead of parsing …
e23b32f 
…it again.
@mbien
Use StandardCharsets.UTF_8 constant instead of "UTF-8" String lookup.
eec6c79
@mbien
Use Colleciton.toArray(T::new) instead of Colleciton.toArray(new T[si…
2e31b23 
…ze]).
@mbien
Small optimizations like better buffer sizing and switch instead of l…
86eabea 
…ong else if chain.
@mbien
Use collection.sort() instead of Collections.sort(col).
0832526
@mbien
Use copy collection copy constructors instead of addAll().
fc8cdba
@mbien
Use ByteArrayOutputStream::toString.
4de79d5
@mbien
Use String::equalsIgnoreCase where applicable.
cb3090f
@mbien
Use set/getProperty methods instead of Hashtable put/get.
92b9932
@mbien
Use try-with-resource and input.transferTo(output) where applicable.
d6ed11c
@mbien
maven dependency updates.
bf4f750
@mbien
skip derby startup if tests are skipped.
1a6f44f
@mbien mbien requested a review from snoopdave October 23, 2021 05:20
snoopdave
snoopdave approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the relayed review. This looks great, so many nice simplifications to IO and encoding. And nice use of a switch in the request mapper.

@mbien
Copy link
Member Author

mbien commented Oct 23, 2021

@snoopdave no worries dave, thanks for the review!

@mbien mbien merged commit 80e12ae into apache:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoopdave snoopdave snoopdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbien @snoopdave