Deployment Automation #137
Conversation
There was a problem hiding this comment.
I don't understand the point of this PR as we already have the ability to produce a Docker file and we provide an example docker-compose.yml setup. Also, this PR introduces arbiutrary formatting changes that are not needed and make it difficult to see what has actally changed.
| @@ -0,0 +1 @@ | |||
| 1.5:a1cf4c44-6035-470e-b080-fd4088b2dc79 | |||
There was a problem hiding this comment.
I don't understand why any of the changes under .vagrant are necessary in this PR.
| @@ -0,0 +1,27 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
Seems like a bad practice to include private keys in our repo.
There was a problem hiding this comment.
agreed, private keys should not be in repos many reasons.
| @@ -0,0 +1,9 @@ | |||
| # This file loads the proper rgloader/loader.rb file that comes packaged | |||
There was a problem hiding this comment.
Why is anything related to Vagrant in this PR, we've got Docker and docker-compose already why do we need Vagrant?
|
|
||
| WORKDIR /usr/local/tomcat | ||
| CMD [ "/usr/local/tomcat/bin/entry-point.sh" ] | ||
| FROM maven:3-openjdk-17-slim as builder |
There was a problem hiding this comment.
Formatting changes should not be included in PRs, only changes essential to the PR.
| @@ -0,0 +1,99 @@ | |||
| # -*- mode: ruby -*- | |||
There was a problem hiding this comment.
again, why do we need Vagrant when we have Docker and Docker compose?
| @@ -1,47 +1,25 @@ | |||
|
|
|||
There was a problem hiding this comment.
Why does this PR remove the license header? Also, any new files shiould include the license header.
| - "5432:5432" | ||
| volumes: | ||
| - type: bind | ||
| source: C:/roller/docker/postgresql-data |
There was a problem hiding this comment.
Is there no way to specify a Docker file like this without OS specific paths like this?
There was a problem hiding this comment.
unless there is a committer who is willing to look over this and maintain the vagrant config, i am going to -1 this.
The main artifacts of this repo are the zip/war. Everything what comes after this can be customized by the user who deploys roller. There is also a docker file serving as example deployment / getting started script.
You could of course host a sample vagrant config in your own repo, but I don't see the purpose of this in the main repo right now esp since we would have to maintain this forever.
repos should also not contain private keys, system specific paths etc but dave already annotated those bits.
| @@ -0,0 +1,27 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
agreed, private keys should not be in repos many reasons.
|
I don't think this is work that we want to merge into Roller. |
Summary
This pull request adds the following deployment scripts and configurations:
Vagrantfilefor setting up the development environmentDockerfilefor containerizing the applicationdocker-compose.ymlfor orchestrating multi-container setupsdeploy.shscript for automating the deployment processWhy This Change Is Necessary
These changes are necessary to automate and streamline the deployment process, making it reproducible and easy to manage.
Testing Done
Checklist