Skip to content

Fix pytest hanging when test fails by closing PostgreSQL connection using with statement #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
Merged

Fix pytest hanging when test fails by closing PostgreSQL connection using with statement #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
948c90f
Generate better geometry pairs for benchmarking binary ST functions
Kontinuation Sep 9, 2025
ae8fe90
Improve the benchmark data generator
Kontinuation Sep 12, 2025
0b446e2
Add context management capability to DBEngines
Kontinuation Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions python/sedonadb/python/sedonadb/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,17 @@ class DBEngine:
of that name.
"""

def close(self):
"""Close the connection - base implementation does nothing"""
pass

def __enter__(self):
return self

def __exit__(self, exc_type, exc_val, exc_tb):
self.close()
return False

@classmethod
def name(cls) -> str:
"""This engine's name
Expand Down Expand Up @@ -399,6 +410,11 @@ def __init__(self, uri=None):
uri = "postgresql://localhost:5432/postgres?user=postgres&password=password"
self.con = adbc_driver_postgresql.dbapi.connect(uri)

def close(self):
"""Close the connection"""
if self.con:
self.con.close()

@classmethod
def name(cls):
return "postgis"
Expand Down
Loading