Skip to content

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented Aug 16, 2017

this is only a simple modify, still remain old complex logic
if we can remove usage of below, consumer init will be very simple.
<cse:rpc-reference id="..." microservice-name="..." schema-id="..."/>

only rpc-reference in xml and missed interface property will block boot and query schema from SC.

wujimin added 2 commits August 16, 2017 15:42
only when xml definition cse:rpc-reference missed interface property, we print warning log and block boot to query schema.

this is a little optimize, if we can remove no interface usage, consumer init will be very very very simple, we are waiting for customer's confirmation.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 85.416% when pulling 32cff6d on wujimin:consumer-init-optimize into ebc3503 on ServiceComb:master.

@wujimin wujimin closed this Aug 17, 2017
@wujimin wujimin deleted the consumer-init-optimize branch August 17, 2017 10:16
@wujimin wujimin changed the title Consumer init optimize JAV-289 Consumer init optimize Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants