[JAV-406]add fallback from cache and used customized cache strategies #172
Conversation
| } | ||
|
|
||
| @Override | ||
| public void record(Invocation invocation, Response response, boolean isSuccess) { |
There was a problem hiding this comment.
what's the relationship between response.isSuccessed() and the parameter isSuccess?
There was a problem hiding this comment.
For bizkeeper, success is based on some specific exceptions than can be customized by developers, e.g. ConnectionException or SocketException. Now if only 499 client exceptions.
| http://www.springframework.org/schema/beans classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd | ||
| http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd"> | ||
|
|
||
| <context:component-scan base-package="io.servicecomb.bizkeeper" /> |
There was a problem hiding this comment.
<context:component-scan base-package="io.servicecomb" />
we already set this in core.
| springmvc: | ||
| codeFirst: | ||
| fallbackFromCache: | ||
| policy: fromcache |
There was a problem hiding this comment.
Can we change the policy name with the camel case just like fromCache, returnNull, throwException?
There was a problem hiding this comment.
OK. I change fromcache to fromCache. But others is compatible.
| @ApiResponses(value = {@ApiResponse(code = 200, response = String.class, message = "xxx"), | ||
| @ApiResponse(code = 490, response = String.class, message = "xxx")}) | ||
| public String fallbackReturnNull(@PathVariable(name = "name") String name) { | ||
| if ("throwexception".equals(name)) { |
There was a problem hiding this comment.
It's better to use the constant string.
|
|
||
| @Override | ||
| public String name() { | ||
| return "returnnull"; |
There was a problem hiding this comment.
Please use the camel case "returnNull" and the constant.
4 participants
No description provided.