Skip to content

Report error instead of warning if rest/highway address format is invalid #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Report error instead of warning if rest/highway address format is invalid #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bf5d5b
Fix code warning
MabinGo Oct 11, 2017
bc920e3
[JAV-433] Error should be reported instead of the warning when the IP…
MabinGo Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...ations/foundation-common/src/main/java/io/servicecomb/foundation/common/net/NetUtils.java
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ private static void doGetIpv4AddressFromNetworkInterface() throws SocketExceptio
}
}
}

return;
}

/**
Expand Down Expand Up @@ -151,18 +149,18 @@ public static IpPort parseIpPortFromURI(String uriAddress) {
*/
public static String getRealListenAddress(String schema, String address) {
if (address == null) {
return address;
return null;
}
try {
URI originalURI = new URI(schema + "://" + address);
IpPort ipPort = NetUtils.parseIpPort(originalURI.getAuthority());
if (ipPort == null) {
LOGGER.warn("address {} not valid.", address);
LOGGER.error("address {} is not valid.", address);
return null;
}
return originalURI.toString();
} catch (URISyntaxException e) {
LOGGER.warn("address {} not valid.", address);
LOGGER.error("address {} is not valid.", address);
return null;
}
}
Expand Down