Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed several bugs about motan rpc plugin #4934

Merged
merged 41 commits into from
Aug 3, 2023

Conversation

coderDylan
Copy link
Contributor

1.Upgraded motan rpc support to the latest stable version
2.Fixed an issue where motan generalization calls failed when arguments were java primitive types or custom types
3.Fixed the motan registry hard coding issue and supported the configuration extension
4.Fixed the schema.sql syntax problem in h2 database scenario

coderDylan and others added 7 commits July 31, 2023 19:54
1.Upgraded motan support to the latest stable version
2.Fixed an issue where motan generalization calls failed when arguments were java primitive types or custom types
3.Fixed the motan registry hard coding issue and supported the configuration extension
4.Fixed the schema.sql syntax problem in h2 database scenario
@yu199195 yu199195 added plugin: motan type: bug Something isn't working labels Aug 1, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Aug 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #4934 (8e63dae) into master (fc97814) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 52.38%.

❗ Current head 8e63dae differs from pull request most recent head 83a3732. Consider uploading reports for the commit 83a3732 to get more accurate results

@@            Coverage Diff            @@
##             master    #4934   +/-   ##
=========================================
  Coverage     63.94%   63.94%           
- Complexity     8529     8532    +3     
=========================================
  Files          1208     1208           
  Lines         35900    35903    +3     
  Branches       3220     3220           
=========================================
+ Hits          22957    22959    +2     
- Misses        11088    11090    +2     
+ Partials       1855     1854    -1     
Files Changed Coverage Δ
...e/shenyu/plugin/motan/proxy/MotanProxyService.java 1.81% <0.00%> (ø)
...nyu/plugin/motan/cache/ApplicationConfigCache.java 57.00% <44.44%> (ø)
...common/dto/convert/plugin/MotanRegisterConfig.java 62.06% <87.50%> (+4.37%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@loongs-zhang
Copy link
Member

please check CI

@moremind
Copy link
Member

moremind commented Aug 1, 2023

oracle/pg/og don't change?

@moremind
Copy link
Member

moremind commented Aug 1, 2023

pls check ci

@coderDylan
Copy link
Contributor Author

oracle/pg/og don't change?

done

@loongs-zhang
Copy link
Member

Is this need to update upgrade sqls ? @coderDylan

@coderDylan
Copy link
Contributor Author

Is this need to update upgrade sqls ? @coderDylan

Yes, mainly insert plugin_handle ...Because the plugin adds new configuration parameters,multiple registries are supported

@moremind
Copy link
Member

moremind commented Aug 2, 2023

pls add my wechat yijia1949

@yu199195 yu199195 merged commit 89cf902 into apache:master Aug 3, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: motan type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants