Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude more generated sources and plugin instrumentation definition … #3561

Merged
merged 5 commits into from
Oct 6, 2019
Merged

Exclude more generated sources and plugin instrumentation definition … #3561

merged 5 commits into from
Oct 6, 2019

Conversation

kezhenxu94
Copy link
Member

…classes

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Test

  • Related issues

#2438

@kezhenxu94 kezhenxu94 added the test Test requirements about performance, feature or before release. label Oct 5, 2019
@kezhenxu94 kezhenxu94 added this to the 6.5.0 milestone Oct 5, 2019
pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch for finding this. Look forward the real test coverage.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 5, 2019

image

The generated codes still counted.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for update about generated codes exclusion.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should add coverage badge back. 30% seems OK.

@wu-sheng wu-sheng merged commit 47f33e6 into apache:master Oct 6, 2019
@kezhenxu94 kezhenxu94 deleted the test/exclude-generated-sources-and-instrumentation-define branch October 6, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants