Prevent RAW_GINKGO unset error in e2e tests #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all environments set particular `RAW_GINKGO` args, causing `make e2e-tests` to fail with an "unset variable" related error. This commit tweaks our `manage_e2e_tests.sh` script to guard against this case.
|
I swear a different dev brought this up at some point in either an Issue or PR (though I can't find that comment now). In any case, I've hit this a number of times across different machines, so seems worth fixing. |
HoustonPutman
approved these changes
Mar 13, 2025
gerlowskija
added a commit
that referenced
this pull request
Mar 14, 2025
Not all environments set particular `RAW_GINKGO` args, causing `make e2e-tests` to fail with an "unset variable" related error. This commit tweaks our `manage_e2e_tests.sh` script to guard against this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all environments set particular
RAW_GINKGOargs, causingmake e2e-teststo fail with an "unset variable" related error.This commit tweaks our
manage_e2e_tests.shscript to guard against this case.