SOLR-16427: Evaluate and fix errorprone rules #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass with these changes and pass |
epugh
reviewed
Sep 22, 2022
epugh
reviewed
Sep 22, 2022
solr/core/src/test/org/apache/solr/update/processor/FieldMutatingUpdateProcessorTest.java
Show resolved
Hide resolved
epugh
reviewed
Sep 22, 2022
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java
Show resolved
Hide resolved
|
I'm hoping to rerun the warnings report from IntelliJ with a before and after this PR, as I suspect these fixes will directly impact those warnings! I love how you are enabling errorprone for these.. I never quite cracked "how to prevent them from coming back" with my work on SOLR-16222. |
risdenk
changed the title
risdenk
requested review from
epugh,
cpoerschke,
gerlowskija,
HoustonPutman,
janhoy,
madrob and
magibney
risdenk
added a commit
that referenced
this pull request
Sep 23, 2022
Enables the following errorprone rules: * `ArrayEquals` * `ArrayHashCode` * `ArrayToString` * `CollectionUndefinedEquality` * `EqualsIncompatibleType` * `FormatString` * `UndefinedEquals` Most of the fixes are straight forward - use `.equals` and `Objects.equals` where appropriate. Used `contentEquals` for char sequences. Make sure to compare `Instant` instead of just `Date`. Ensure proper string format number of arguments. Make sure to use proper Array methods for `hashCode` and `toString`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16427
Enables the following errorprone rules:
ArrayEqualsArrayHashCodeArrayToStringCollectionUndefinedEqualityEqualsIncompatibleTypeFormatStringUndefinedEqualsMost of the fixes are straight forward - use
.equalsandObjects.equalswhere appropriate. UsedcontentEqualsfor char sequences. Make sure to compareInstantinstead of justDate. Ensure proper string format number of arguments. Make sure to use proper Array methods forhashCodeandtoString