Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update releaseWizard.py to support offline gpg key #1288

Merged

Conversation

magibney
Copy link
Contributor

The release wizard detection of gpg keys fails in the event that the main key is offline (which causes the script output for gpg --list-secret-keys to display slightly differently). This PR introduces a minor tweak to parsing only, to enable gpg key detection to work in such cases.

The relevant section (full flag description from man gpg below) is A # after the initial tags sec or ssb means that the secret key or subkey is currently not usable.

       --list-secret-keys
       -K     List the specified secret keys.  If no keys are specified, then
              all known secret keys are listed.  A # after the initial tags
              sec or ssb means that the secret key or subkey is currently not
              usable.  We also say that this key has been taken offline (for
              example, a primary key can be taken offline by exporting the key
              using the command --export-secret-subkeys).  A > after these
              tags indicate that the key is stored on a smartcard.  See also
              --list-keys.

@magibney magibney requested a review from janhoy January 13, 2023 15:21
@magibney magibney merged commit ac32afd into apache:main Jan 13, 2023
magibney added a commit that referenced this pull request Jan 17, 2023
magibney added a commit that referenced this pull request Jan 17, 2023
javanna pushed a commit to apache/lucene that referenced this pull request Jan 19, 2023
javanna pushed a commit to apache/lucene that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants