Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.fasterxml.jackson:jackson-bom to v2.15.2 #1599

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Apr 30, 2023

This PR contains the following updates:

Package Type Update Change
com.fasterxml.jackson:jackson-bom dependencies minor 2.14.2 -> 2.15.2

Configuration

📅 Schedule: Branch creation - "* * * * 0" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@solrbot solrbot force-pushed the renovate/com.fasterxml.jackson-jackson-bom-2.x branch 3 times, most recently from 7eca645 to 9942359 Compare May 4, 2023 16:34
@solrbot solrbot force-pushed the renovate/com.fasterxml.jackson-jackson-bom-2.x branch from 9942359 to 4180064 Compare May 21, 2023 23:35
@solrbot solrbot changed the title Update dependency com.fasterxml.jackson:jackson-bom to v2.15.0 Update dependency com.fasterxml.jackson:jackson-bom to v2.15.1 May 21, 2023
@solrbot solrbot force-pushed the renovate/com.fasterxml.jackson-jackson-bom-2.x branch from 4180064 to 5e2beea Compare May 24, 2023 13:56
@solrbot solrbot force-pushed the renovate/com.fasterxml.jackson-jackson-bom-2.x branch from 5e2beea to 80ee508 Compare June 4, 2023 22:23
@solrbot solrbot changed the title Update dependency com.fasterxml.jackson:jackson-bom to v2.15.1 Update dependency com.fasterxml.jackson:jackson-bom to v2.15.2 Jun 4, 2023
@solrbot solrbot force-pushed the renovate/com.fasterxml.jackson-jackson-bom-2.x branch from 80ee508 to 06080b7 Compare June 5, 2023 08:00
@noblepaul noblepaul merged commit 98ca35b into apache:main Jun 7, 2023
@solrbot solrbot deleted the renovate/com.fasterxml.jackson-jackson-bom-2.x branch June 7, 2023 04:27
@risdenk
Copy link
Contributor

risdenk commented Jun 7, 2023

@noblepaul This also updated com.fasterxml.woodstox:woodstox-core to 6.5.1 which should have been updated in versions.props.

@risdenk
Copy link
Contributor

risdenk commented Jun 7, 2023

Fixed versions.props in f70696a

@janhoy
Copy link
Contributor

janhoy commented Jun 7, 2023

Not necessarily a bug per se, lock file may by design have higher versions than in props. The documentation of gradle-consistent-versions plugin https://github.com/palantir/gradle-consistent-versions#versionsprops-lower-bounds-for-dependencies says:

versions.props: lower bounds for dependencies
Specify versions for your direct dependencies in a single root-level versions.props file. Think of these versions as the minimum versions your project requires.

Once in a while we need to override the minimum version of a lib, but once gradle selects a compatible version by itself, perhaps we could simply remove the override of woodstox now?

> Task :why
com.fasterxml.woodstox:woodstox-core:6.5.1
	projects -> 6.5.1
	com.fasterxml.jackson.dataformat:jackson-dataformat-xml -> 6.5.1
	org.apache.tika:tika-parsers -> 6.3.1

@risdenk
Copy link
Contributor

risdenk commented Jun 7, 2023

woodstox-core is explicitly used as a dependency in solr/core/build.gradle and solr/modules/s3-repository/build.gradle and want to make sure it stays at the more recent version.

Agreed its a minimum but if we have a versions.props line - it should line up with the dependency version in verisons.lock. Its incorrect to just let the older versions.props line just sit there out of date. I know because I went through and cleaned up most of these forgotten properties a while ago.

It might be possible to remove versions.props line for woodstox-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants