Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16970: Fix windows script #1975

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

HoustonPutman
Copy link
Contributor

@HoustonPutman HoustonPutman marked this pull request as ready for review October 3, 2023 19:30
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gnarly levels of command scripting!

@stillalex
Copy link
Member

I can't even tell what is happening here. good stuff @HoustonPutman!

Copy link
Contributor

@elyograg elyograg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMD scripts are voodoo. I do not see how this fixes the problem, but it does. Awesome job @HoustonPutman!

@HoustonPutman HoustonPutman merged commit 74ad7bb into apache:main Oct 4, 2023
4 checks passed
@HoustonPutman HoustonPutman deleted the fix-windows branch October 4, 2023 13:56
HoustonPutman added a commit that referenced this pull request Oct 4, 2023
HoustonPutman added a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants