Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency commons-codec:commons-codec to v1.16.1 #2266

Merged

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Feb 15, 2024

This PR contains the following updates:

Package Type Update Change
commons-codec:commons-codec (source) dependencies patch 1.16.0 -> 1.16.1

Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@github-actions github-actions bot added the dependencies Dependency upgrades label Feb 15, 2024
Copy link
Contributor

@cpoerschke cpoerschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://commons.apache.org/proper/commons-codec/changes-report.html#a1.16.1 mentions version bumps for these three commons-parent commons-lang3 commons-io -- might be worth checking versions relative to Solr's current dependencies.

solr/licenses/jakarta.inject-2.6.1.jar.sha1 Outdated Show resolved Hide resolved
@cpoerschke cpoerschke self-assigned this Feb 15, 2024
@cpoerschke cpoerschke self-requested a review February 15, 2024 17:51
@cpoerschke
Copy link
Contributor

https://commons.apache.org/proper/commons-codec/changes-report.html#a1.16.1 mentions version bumps for these three commons-parent commons-lang3 commons-io -- might be worth checking versions relative to Solr's current dependencies.

... commons-parent from 58 to 66 ...
We don't have a dependency on that currently.

... commons-lang3 from 3.12.0 to 3.14.0 ...
We are on the latter already via #2139 PR.

... commons-io from 2.13.0 to 2.15.1 ...
We have #2049 pending to upgrade to the latter.

@cpoerschke cpoerschke removed their assignment Feb 16, 2024
@solrbot solrbot force-pushed the renovate/commons-codec-commons-codec-1.x branch from 390cac3 to 7b41543 Compare February 27, 2024 10:18
@janhoy
Copy link
Contributor

janhoy commented Feb 27, 2024

@cpoerschke Commons-io depends on a new release of forbidden-APIs, policeman-tools/forbidden-apis#244, so we can keep waiting for these other. Marking as draft for now (although passing tests already prove that commons-codec works with commons-io 2.14, yea?).

@janhoy janhoy marked this pull request as draft February 27, 2024 12:44
@cpoerschke
Copy link
Contributor

... We have #2049 pending to upgrade to the latter.

That's merged now. So tentatively requested rebase and will tentatively mark as ready-to-review then.

@cpoerschke cpoerschke marked this pull request as ready for review April 11, 2024 10:48
@solrbot solrbot force-pushed the renovate/commons-codec-commons-codec-1.x branch from 7b41543 to 313df61 Compare April 11, 2024 12:39
@cpoerschke cpoerschke self-assigned this Apr 12, 2024
@cpoerschke cpoerschke merged commit c36c675 into apache:main Apr 12, 2024
3 checks passed
asfgit pushed a commit that referenced this pull request Apr 12, 2024
@cpoerschke cpoerschke removed their assignment Apr 12, 2024
@solrbot solrbot deleted the renovate/commons-codec-commons-codec-1.x branch April 12, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency upgrades
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants